From 399f4f86472c767595254bb662534826fb433b58 Mon Sep 17 00:00:00 2001
From: "cl349@firebug.cl.cam.ac.uk" <cl349@firebug.cl.cam.ac.uk>
Date: Thu, 1 Sep 2005 10:08:53 +0000
Subject: [PATCH] Cleanup domain listing. Signed-off-by: Christian Limpach
 <Christian.Limpach@cl.cam.ac.uk>

---
 tools/python/xen/xend/XendDomain.py          | 38 ++++++++++----------
 tools/python/xen/xend/server/SrvDomainDir.py |  5 ++-
 tools/python/xen/xend/server/event.py        |  2 +-
 3 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/tools/python/xen/xend/XendDomain.py b/tools/python/xen/xend/XendDomain.py
index 3959b2e917..080fc4ae8b 100644
--- a/tools/python/xen/xend/XendDomain.py
+++ b/tools/python/xen/xend/XendDomain.py
@@ -75,8 +75,26 @@ class XendDomain:
 
         @return: domain objects
         """
+        self.refresh()
         return self.domains.values()
-    
+
+    def list_sorted(self):
+        """Get list of domain objects, sorted by name.
+
+        @return: domain objects
+        """
+        doms = self.list()
+        doms.sort(lambda x, y: cmp(x.name, y.name))
+        return doms
+
+    def list_names(self):
+        """Get list of domain names.
+
+        @return: domain names
+        """
+        doms = self.list_sorted()
+        return map(lambda x: x.name, doms)
+
     def onVirq(self, event, val):
         """Event handler for virq.
         """
@@ -265,24 +283,6 @@ class XendDomain:
         else:
             self._delete_domain(id)
 
-    def domain_ls(self):
-        """Get list of domain names.
-
-        @return: domain names
-        """
-        self.refresh()
-        doms = self.domains.values()
-        doms.sort(lambda x, y: cmp(x.name, y.name))
-        return map(lambda x: x.name, doms)
-
-    def domain_ls_ids(self):
-        """Get list of domain ids.
-
-        @return: domain names
-        """
-        self.refresh()
-        return self.domains.keys()
-
     def domain_create(self, config):
         """Create a domain from a configuration.
 
diff --git a/tools/python/xen/xend/server/SrvDomainDir.py b/tools/python/xen/xend/server/SrvDomainDir.py
index 613841ddff..2b5f873fd3 100644
--- a/tools/python/xen/xend/server/SrvDomainDir.py
+++ b/tools/python/xen/xend/server/SrvDomainDir.py
@@ -146,11 +146,10 @@ class SrvDomainDir(SrvDir):
         if not url.endswith('/'):
             url += '/'
         if use_sxp:
-            domains = self.xd.domain_ls()
+            domains = self.xd.list_names()
             sxp.show(domains, out=req)
         else:
-            domains = self.xd.list()
-            domains.sort(lambda x, y: cmp(x.name, y.name))
+            domains = self.xd.list_sorted()
             req.write('<ul>')
             for d in domains:
                req.write('<li><a href="%s%s"> Domain %s</a>'
diff --git a/tools/python/xen/xend/server/event.py b/tools/python/xen/xend/server/event.py
index 360cd47a9b..eee9b0594c 100644
--- a/tools/python/xen/xend/server/event.py
+++ b/tools/python/xen/xend/server/event.py
@@ -186,7 +186,7 @@ class EventProtocol(protocol.Protocol):
 
     def op_domain_ls(self, name, v):
         xd = xroot.get_component("xen.xend.XendDomain")
-        return xd.domain_ls()
+        return xd.list_names()
 
     def op_domain_configure(self, name, v):
         domid = sxp.child_value(v, "dom")
-- 
2.30.2